Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix staging area path buildup #7363

Merged
merged 1 commit into from
Sep 21, 2021
Merged

fix staging area path buildup #7363

merged 1 commit into from
Sep 21, 2021

Conversation

nonsense
Copy link
Member

This PR is fixing the OS specific separator that was introduced in #7276 and properly building up the deals staging area path.

@nonsense nonsense requested a review from a team as a code owner September 21, 2021 14:46
@codecov
Copy link

codecov bot commented Sep 21, 2021 •
edited
Loading

Codecov Report

Merging #7363 (c7e4217) into master (2437a41) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7363      +/-   ##
==========================================
- Coverage   39.18%   39.16%   -0.03%     
==========================================
  Files         614      614              
  Lines       65004    65005       +1     
==========================================
- Hits        25471    25457      -14     
- Misses      35129    35147      +18     
+ Partials     4404     4401       -3
Impacted Files Coverage Δ
node/modules/storageminer.go 62.31% <100.00%> (+0.06%) ⬆️
storage/wdpost_sched.go 75.24% <0.00%> (-5.95%) ⬇️
chain/actors/builtin/paych/paych.go 16.88% <0.00%> (-5.20%) ⬇️
extern/sector-storage/manager_calltracker.go 57.70% <0.00%> (-4.85%) ⬇️
chain/sync_manager.go 67.39% <0.00%> (-4.66%) ⬇️
storage/wdpost_changehandler.go 97.64% <0.00%> (-0.95%) ⬇️
chain/messagepool/selection.go 80.12% <0.00%> (-0.41%) ⬇️
blockstore/badger/blockstore.go 57.28% <0.00%> (-0.41%) ⬇️
node/impl/storminer.go 22.46% <0.00%> (-0.40%) ⬇️
chain/messagepool/messagepool.go 56.93% <0.00%> (-0.25%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2437a41...c7e4217. Read the comment docs.

@magik6k magik6k merged commit fe56995 into master Sep 21, 2021
@magik6k magik6k deleted the nonsense/fix-filepath-join branch September 21, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nonsense @magik6k